This PR fixes two issues in the COF class. The first being incorrect naming of the n_neighbors parameter. The incorrect naming can cause issues with the get_params() method of the BaseDetector parent. The second change moves the argument checking procedure to the fit() method to adhere more closely to the scikit-learn guidelines for developing estimators. Argument checking in the init() method can cause scikit-learn cloning of an object of this class to fail.
All Submissions Basics:
-
Have you followed the guidelines in our Contributing document? -
Have you checked to ensure there aren't other open Pull Requests for the same update/change? -
Have you checked all Issues to tie the PR to a specific one?
All Submissions Cores:
-
Have you added an explanation of what your changes do and why you'd like us to include them? -
Have you written new tests for your core changes, as applicable? -
Have you successfully ran tests with your changes locally? -
Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor? -
Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.