Skip to content
GitLab

Add CSS color variables to Card component

Closed Administrator requested to merge github/fork/tagliala/feature/card-css-variables into main

Created by: tagliala

Hi, this is an attempt to provide variables for the Card component, but I have a couple of questions

  • $card-color and $card-cap-color are defined as null. This has the effect of rules being generated with SCSS, but it will generate empty css variables.
    • Is it fine to have empty CSS variables?
    • Should the default value change to inherit?
    • if the default value change from null to inherit, should it be considered a breaking change?
  1. Should the conditional rules in @if $nav-tabs-link-active-bg != $card-bg moved out from if?