Skip to content
GitLab

Fix crash when pressing ArrowUp the first time

Closed Administrator requested to merge github/fork/tkrotoff/fix-dropdown-ArrowUp into master

Created by: tkrotoff

Edit: already done in #30597

Fix crash in dropdown: "Uncaught TypeError: Cannot read property 'focus' of undefined"

When opening the dropdown and pressing ArrowUp for the first time. Crash already present here: https://twbs-bootstrap.netlify.com/docs/4.3/components/dropdowns/

https://github.com/twbs/bootstrap/blob/f0abe26b98ade4d6a2d0b234758a94ea33b85388/js/src/dropdown.js#L482

items.indexOf(event.target) || 0 gives -1 || 0 which returns... -1... See explanations "Why are JavaScript negative numbers not always true or false?"