I did a first approach on an offcanvas component. Αll of us, have used custom solutions, but maybe an official version, would be more stable.
Do you find it interesting? May I continue on this?
Preview: https://deploy-preview-29017--twbs-bootstrap.netlify.app/docs/5.0/components/offcanvas/
TODO:
-
we need to see if we can stop body scroll -
maybe blur the bg if it doesn't have any performance hit -
tweak blur, the current blur is too much IMO (XhmikosR) -
Remove height from bottom offcanvas -
Provide some default theming (white background, maybe a border or shadow like the modals) -
Disable body scrolling by default. -
measure FPS when blurring the bg (@XhmikosR i need guidance) -
update offcanvas example to use this (also move it away from the experimental category) -
reindent and fix missing end tags in the doc examples -
switch to event.key
-
add more content in right, bottom examples -
<div class="h4">
should be changed toh4
or similar? -
Make sure the element is hidden and not offscreen when inactive -
enforce focus, only on open element -
Enable blur by default? -
Revert the scrollbar decoupling -
Consistent behavior of modals and offcanvas (eg. same way of setting a backdrop) #32439 -
non-text elements inside button related issue #32372 (closed), #31646 (closed) -
Make sure all data attributes and any CSS vars are prefixed -
Bring back the backdrop option, but keep it enabled by default -
Make sure we aren't using any recently changed mr, etc classes -
Should the backdrop transition be the same as the offcanvas one? Right now, backdrop shows instantly but finishes hiding after the offcanvas is closed .(GeoSot: it will be changed when #32439 is merged) -
Decide about the name: offcanvas
,off-canvas
etc -
Maybe rename the classes to consider RTL? Not sure if it's needed -
Fix BrowserStack tests -
spell checking from a native English speaker (@mdo?) -
check accessibility (@patrickhlauke) -
clean up/squash patches manually
Fixes #27033 (closed), fixes #24718 (closed).
mdo's TODO:
-
Finish and merge this PR -
Undo the Offcanvas example change for now (we'll replace that later)
-
-
Close any other PRs -
Iterate on the docs a bit more -
Detach and de-dupe the backdrop in #32439