v5: Offcanvas ESC keypress doesn't prevent default
Created by: moeriki
Prerequisites
-
I have searched for duplicate or closed issues -
I have validated any HTML to avoid common problems -
I have read the contributing guidelines
Describe the issue
Pressing "Escape" in an open Offcanvas closes it. But the event is propagated to the browser which (ao) makes the browser leave fullscreen mode.
This behaviour is correct in other overlay components such as dropdown and modal.
Reduced test cases
https://codepen.io/moeriki/pen/rNGLBvW
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Safari, Firefox
What version of Bootstrap are you using?
v5.1.3
Fix
The fix might be just adding event.preventDefault()
here…
https://github.com/twbs/bootstrap/blob/main/js/src/offcanvas.js#L194