[Bug] Order classes also generate a class .order#{$infix}-0 for every infix
Created by: kopax
Order classes are starting from 0 instead of 1 for every infix
It should be like :
Generate css is wrong:
.order-1-0 {
order: 0;
}
.order-1-1 {
order: 1;
}
.order-1-2 {
order: 2;
}
.order-1-3 {
order: 3;
}
.order-1-4 {
order: 4;
}
.order-1-5 {
order: 5;
}
.order-1-6 {
order: 6;
}
.order-1-7 {
order: 7;
}
.order-1-8 {
order: 8;
}
.order-1-9 {
order: 9;
}
.order-1-10 {
order: 10;
}
.order-1-11 {
order: 11;
}
.order-1-12 {
order: 12;
}
Possible fix:
// Framework grid generation
//
// Used only by Bootstrap to generate the correct number of grid classes given
// any value of `$grid-columns`.
@mixin make-grid-columns($columns: $grid-columns, $gutter: $grid-gutter-width, $breakpoints: $grid-breakpoints) {
// Common properties for all breakpoints
%grid-column {
position: relative;
width: 100%;
padding-right: $gutter / 2;
padding-left: $gutter / 2;
}
@each $breakpoint in map-keys($breakpoints) {
$infix: breakpoint-infix($breakpoint, $breakpoints);
// Allow columns to stretch full width below their breakpoints
@for $i from 1 through $columns {
.col#{$infix}-#{$i} {
@extend %grid-column;
}
}
.col#{$infix},
.col#{$infix}-auto {
@extend %grid-column;
}
@include media-breakpoint-up($breakpoint, $breakpoints) {
// Provide basic `.col-{bp}` classes for equal-width flexbox columns
.col#{$infix} {
flex-basis: 0;
flex-grow: 1;
max-width: 100%;
}
.col#{$infix}-auto {
flex: 0 0 auto;
width: auto;
max-width: 100%; // Reset earlier grid tiers
}
@for $i from 1 through $columns {
.col#{$infix}-#{$i} {
@include make-col($i, $columns);
}
}
.order#{$infix}-first { order: -1; }
.order#{$infix}-last { order: $columns + 1; }
- @for $i from 0 through $columns {
+ @for $i from 1 through $columns {
.order#{$infix}-#{$i} { order: $i; }
}
// `$columns - 1` because offsetting by the width of an entire row isn't possible
- @for $i from 0 through ($columns - 1) {
+ @for $i from 1 through ($columns - 1) {
@if not ($infix == "" and $i == 0) { // Avoid emitting useless .offset-0
.offset#{$infix}-#{$i} {
@include make-col-offset($i, $columns);
}
}
}
}
}
}