Created by: imajes
There are a couple other PRs to deliver Rails 5 compat, but this one should pass specs, and be mergeable.
I've focused mostly on:
- the few small fixes required to actually bring compat
- supporting appraisals for rails 4 & 5
- re-introducing fuubar, which is now rspec compatible again
- silencing or fixing a number of deprecation notices
Regarding the strong params issue, my approach doesn't blanket permit (which is going to be a security vulnerability, due to the abstract way it's implemented and the potential for scriptable exploits). Instead it permits specific, expected params. I don't know if this is sufficient, and we may need to extend this with some of the ATTRIBUTE
constants to encapsulate all of the expected params. Will text this further as I integrate administrate
into my own app.
There is one deprec notice remaining that is particularly annoying; resolving it removes rails4 test compatibility. I considered wrapping the calls in a deprecation silencer, but felt that isn't a good idea given how it may be missed later. One option may be overriding the specific deprecation notice to silence it.
-- since resolved that with a wrapper def.