Skip to content
GitLab

Left join in order to support searching both a belongs_to and a field…

Closed Administrator requested to merge github/fork/motdotla/master into master

Created by: motdotla

… on the root entity

First, I love Administrate. ♥ Thank you for creating such a straightforward yet reasonably customizable dashboard. It hits the perfect sweet spot.

This PR is to fix a search issue I ran up against.

In the scenario, where I have configured search to both a belongs_to searchable_field AND some other_field in the root entity, the following happens:

  1. I can successfully search the belongs_to belongs_to.searchable_field when the root entity's belongs_to is assigned
  2. I can successfully search the belongs_to belongs_to.searchable_field when the root entity's belongs_to is null
  3. I can successfully search the other_field when the root entity's belongs_to is assigned
  4. I can NOT successfully search the other_field when the root entity's belongs_to is null

This PR fixes problem #4 (caused by an inner join) by using a left join.

Is this PR useful?