Skip to content
GitLab

fix valid subset when benchmarking

Merged Administrator requested to merge github/fork/roywei/fix_argument into main

Created by: roywei

Patch Description fix #287 (closed) When I test training code and enabled benchmarking, it will throw valid_subsets referenced before assignment error

Command:

opt-baselines -n 1 -g 8 -p test_v0 --model-size 125m --aws --benchmark --checkpoints-dir /fsx/metaseq_models/ --no-save-dir

Error:

4:     hyperparam("--valid-subset", ",".join(f"valid/{ss}" for ss in valid_subsets)),
4: UnboundLocalError
4: : local variable 'valid_subsets' referenced before assignment

Testing steps

After this fix works fine with --benchmark argument

Considerations before submitting:

  • Was this discussed/approved via a Github issue?
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests? -->