Skip to content
GitLab

Solve concurrent map read and map write by making Fieldmap thread-safe & avoiding recycling of addresses

Merged Administrator requested to merge github/fork/waheedoo/make_field_map_thread_safe into main

Created by: waheedoo

We tried to use the library as it is in our integration, but we found out that it has some serious issues:

  1. Fieldmap is not thread-safe.
  2. Recycling of quickfix.Message addresses and re-using them are causing a problem when forwarding these addresses and reading them via:

FromApp(message *Message, sessionID SessionID) MessageRejectError

FromApp(message *Message, sessionID SessionID) MessageRejectError

In this PR we solved both issues, and it works now perfectly fine for us.

This PR should solve the following issues as well: https://github.com/quickfixgo/quickfix/issues/460 https://github.com/quickfixgo/quickfix/issues/372 https://github.com/quickfixgo/quickfix/issues/371 https://github.com/quickfixgo/quickfix/issues/320