metainfo file installed in the wrong place
Created by: rathann
Information
- Solaar version (
solaar --version
orgit describe --tags
if cloned from this repository): 1.0.4-57-g69f889e3 - Distribution: Fedora
- Kernel version (ex.
uname -srmo
): N/A - Output of
solaar show
: N/A
Describe the bug
The metainfo.xml
file gets installed into the wrong location, i.e. /usr/share/metainfo/io.github.pwr_solaar.solaar.metainfo.xml/metainfo.xml
.
To Reproduce
Steps to reproduce the behavior (this is part of RPM package build process, hence the --root xxx
option):
...
/usr/bin/python3 setup.py install -O1 --skip-build --root /builddir/build/BUILDROOT/solaar-1.0.4-3.fc33.x86_64
...
running install_data
creating /builddir/build/BUILDROOT/solaar-1.0.4-3.fc33.x86_64/usr/share
...
creating /builddir/build/BUILDROOT/solaar-1.0.4-3.fc33.x86_64/usr/share/metainfo
creating /builddir/build/BUILDROOT/solaar-1.0.4-3.fc33.x86_64/usr/share/metainfo/io.github.pwr_solaar.solaar.metainfo.xml
copying share/solaar/metainfo.xml -> /builddir/build/BUILDROOT/solaar-1.0.4-3.fc33.x86_64/usr/share/metainfo/io.github.pwr_solaar.solaar.metainfo.xml
...
Screenshots N/A
Additional context
The correct location is: /usr/share/metainfo/io.github.pwr_solaar.solaar.metainfo.xml
(a file under /usr/share/metainfo
, not a directory).
The solution is to rename metainfo.xml
to io.github.pwr_solaar.solaar.metainfo.xml
and install it under /usr/share/metainfo
in setup.py
. I'll send a PR shortly.