Skip to content
GitLab

Revert writeHeaders method and add preserveHeaderKeyCase option

Merged Yuta Shimizu requested to merge github/fork/pachirel/use-header-key-only into master

My change (#1098) has side effect because of the header values of rawHeaders are not always same with the values of headers. ( #1101 (closed), #1102, #1103 (closed)) 🙇

This PR includes these changes to solve it:

  1. Overwrite only key, not value.
  2. Overwrite key if raw header key is available.
  3. Add preserveHeaderKeyCase option (default: false).

@jcrugzz I'd like to hear your thought. 🍣

I have to add specs before marge this. Sorry for any inconvenience, and thanks to all.