As discussed in https://github.com/facebook/buck/issues/2623, this change will use the original test class name instead of the test suite name when generating the test output XML when run against a JUnit suite. I've based this change on the dev
branch as it doesn't seem the kind of thing that needs to hit the stable branch urgently.
I've tried to keep the change as small as possible by overloading the TestCaseSummary
constructor to default the new testSuite
parameter to false
, so that all the other usages of this aren't affected, but if it's better to push this default up to the places where this class is instantiated then I can do that instead!
One thing to note: I originally built this change on top of master
, but figured that it was probably better suited to dev
. It all seemed to work for me on the stable build, however since rebasing the change onto the dev
branch I can no longer build the project? I don't know if this is because I'm trying to build using the latest Buck release, but it gives me an error parsing buck/programs/defs.bzl
(name 'name' is not defined
).