Skip to content
GitLab

Fix race condition on Swift build

Closed Administrator requested to merge github/fork/zayhero-zz/zayhero_race_cond_fixing into master

Created by: zayhero-zz

In PR #1164, we introduce the logic to allow SwiftCompile use the header maps to built bridging headers. However, we encounter race condition issue when we building with this logic.

The headers maps, is generated by CxxLibraryDescription, and SwiftCompile step is generated by SwiftLibraryDescription. These two build rules are running in parallel, so its not guarantee that header maps are ready when we running SwiftCpmile.

To fix this issue, I am making changes to:

  1. passing the headers from AppleLibraryDescription and AppleBinaryDescription to SwiftLibraryDescription
  2. in SwiftLibraryDescription, use the headers to generate symlink tree build rules for headers
  3. force SwiftCompile build rule depends on the symlink tree build rules

@ryu2 @nguyentruongtho Could you take a look? Thanks!