Skip to content
GitLab

Fix buffer_size calculations for AudioFrame planes

Closed Jeremy Lainé requested to merge github/fork/jlaine/audio-frame-buffer-size into develop

This PR fixes several misunderstandings concerning AudioFrame buffer sizes:

  • for audio, "line size" and "buffer size" are equivalent, as there is only ever a single "line".

  • only linesizes[0] is ever populated, and it gives you the buffer size of each plane.

  • we do not need to recalculate anything upon putting frames into an AudioFrame, the buffer size does not change.

  • "align" is not a boolean, it can be any power of two.

We stop carrying around "align", "nb_channels" and "nb_planes", they are not needed.