Created by: MichaelMarner
This PR closes #9955 (closed) by only removing the import for dart:typed_data
if there are no parameters AND no responses of type UInt8List
.
Previously only parameters were being checked, meaning invalid dart code would be generated if there was a UInt8List
response, because the import would have been removed.
Have tested against the example I provided in the bug report, as well as our own codebase where the error was first identified.
Have run ./bin/generate-samples.sh
, but as the Petstore API does not have any file responses, there were no changes to the generated code.
@swipesight @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob (2020/12)
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.3.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.