Merged
requested to merge github/fork/dhutchison/bug/5805-skipIfSpecIsUnchanged-classpath into master
Created by: dhutchison
The skipIfSpecIsUnchanged
configuration setting to the maven plugin did not work when the input spec came from a classpath resource, which could lead to infinite build loops when the plugin was used in eclipse.
Fix #5805 (closed)
The CodeGenMojo
appears to have already had support for creating hashes of input specs from different locations, but an incorrect if
check was preventing these non-filesystem locations having hashes created.
Two additional test methods have been added to test that a spec from the classpath can respect the skipIfSpecIsUnchanged
setting.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.