Created by: krzema12
Issue
[BUG][kotlin-client][multiplatform] "NoSuchMethodError" in runtime when starting ktor server with Kotlin 1.5.10 · Issue #9805 · OpenAPITools/openapi-generator (https://github.com/OpenAPITools/openapi-generator/issues/9805)
Details
The goal of this change is to make Kotlin multiplatform template work with the newest Kotlin version (1.5.10). Without these changes, consuming generated module from a Kotlin 1.5-based module with a Ktor server results in a runtime exception when installing the JSON feature.
My guess is that due to some breaking changes kotlinx.serialization. For consistency, all kotlinx libraries were updated, to adhere to the recommended versions mentioned here: https://kotlinlang.org/docs/releases.html#release-details
This change is meant to be as simple as possible - just bumping the versions and making minimal necessary adjustments. I'm planning to introduce other changes (remove unneeded stuff, address warnings which will become errors in the future, add end-to-end tests if not present, and so on) in separate PR(s).
Testing done
- ran integration tests (
mvn integration-test -f samples/client/petstore/kotlin-multiplatform
) - created an entry point in the generated sample project and made a few test calls. I didn't test all APIs, it was rather meant to be a smoke test
To be clarified
- are there any end-to-end tests that actually try to call the Petstore service with the generated module?
- how to ensure there are no regressions in other Kotlin templates that reuse the shared pieces of template?
- is
master
the right target branch for this change? The policy is confusing to me
I'd expect there are some tests ran by the CI that will address my above concerns. That's why I'm posting this PR anyway, to see what workflows GitHub will trigger, and to get feedback from the community.
FYI
Kotlin technical committee: @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.