Skip to content
GitLab

[BUG][typescript-inversify] Sets `isCollectionFormatMulti` flag to true on multi-file uploads

Merged Administrator requested to merge github/fork/BradenM/fix/ts-inversify-collectionfmtmulti into master

Created by: BradenM

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Pinging TypeScript technical committee members: @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

Details

Resolves the same issue for ts-inversify that was fixed in #8105, #8376 for ts-axios and ts-fetch, respectively.

Quoting @BrMtssk from #8105:

The logic to update the flag was moved to postProcessParameter, as op.allParams contains a copy of the parameter, and not the reference.

Therefore, op.formParams was still returning the parameters with the 'isCollectionFormatMulti' flag set to false.