Created by: spacether
Adds hasDiscriminatorWithNonEmptyMapping This template variable can be used to tell if there is or isn't a discriminator that needs to be defined. This variable is needed in addition to the discriminator one because in by python-experimental branch, the discriminator has an indent applied to it. That indentation makes it impossible to generate code to check discriminator presence at the right indentation level (at the model level). We need a schema level boolean variable that says the discriminator exists or not and this is it.
This variable can be used to determine if a custom schema or model needs to be written for an object schema. A custom object schema model will need to be made if any of these conditions are met
- hasVars
- hasValidation
- isNullable
- hasRequiredVars
- additionalPropertiesIsAnyType is False
- hasDiscriminatorWithNonEmptyMapping
This will be used to generate DictSchemas only when needed in https://github.com/OpenAPITools/openapi-generator/pull/8325
discriminators are only supported in request bodies and response payloads per OpenApi But this interface is needed on all Java classes that implement Schema to allow robust generation by templates. So it's needed in:
- CodegenModel
- CodegenProperty
- CodegenParameter
- CodegenResponse
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.