Skip to content
GitLab

[csharp-netcore][httpclient] Issues managing error statuses

Merged Administrator requested to merge github/fork/lucamazzanti/fix-errors into master

Created by: lucamazzanti

Comparing the behavior with Restsharp I found an issue.

  1. When giving a bad status code 400 or higher with a content, it throws an exception trying to deserialize the type T.
  2. When something goes wrong in the non async part, it thorws an AggregateException containing the ApiException, this is not expexted.
  3. The rawContent contains bad data the class name of the stream printed not the content.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Blackclaws