Created by: jmini
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.3.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @OpenAPITools/generator-core-team @OpenAPITools/openapi-generator-collaborators
Description of the PR
As discussed https://github.com/OpenAPITools/openapi-generator/pull/889#issuecomment-416980977, the implementation proposed in https://github.com/OpenAPITools/openapi-generator/pull/889 needs to be adapted.
Swagger-Parser is doing the conversion from x-nullable
OASv2 to nullable
OASv3.
See an example in https://github.com/swagger-api/swagger-parser/issues/810.
This PR removes reading x-nullable
extension from our code, because the extension will only be available in OASv3. In v3 having them make no sense as pointed out by @wing328.
There is still an open issue: https://github.com/swagger-api/swagger-parser/issues/820 to have the formData parameter handled in swagger. I added a reference in near to the commented unit-test.