Skip to content
GitLab

[php-slim4] Follow PDS skeleton

Merged Administrator requested to merge github/fork/ybelenko/php_slim4_pds_skeleton into master

Created by: ybelenko

I don't like that index.php not in public folder. It's also great opportunity to follow php-pds/skeleton pattern.

I don't know where should be put generated source files, not in bin I think and neither in src. So I didn't change generated library files location for a time being(still in lib folder).

I've checked build locally, no errors.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
$  composer test && composer phpcs
> phpunit
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

IIIIIIIIIIIIIIIIIIIIIIII.III.IIIIIII.IIIIIII.III.IIIIIIIII.....  63 / 112 ( 56%)
.................................................               112 / 112 (100%)

Time: 00:00.116, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 112, Assertions: 137, Incomplete: 53.
> phpcs
........................... 27 / 27 (100%)


Time: 1.68 secs; Memory: 12MB

cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon