Skip to content
GitLab

[Bash] escape tabs properly

Merged Administrator requested to merge github/fork/avbenavides/master into master

Created by: avbenavides

Bash Client Escapes parameters with a 't' to %3.1.2 and leaves tabs unescaped Fixes https://github.com/OpenAPITools/openapi-generator/issues/7303

Bash Client Escapes parameters with a 't' to %3.1.2 and leaves tabs unescaped

openapitools/openapi-generator-cli Version 5.0.0-SNAPSHOT

Command used to generate:

docker run --rm -v $(git rev-parse --show-toplevel)/lt-frontend/:/local openapitools/openapi-generator-cli generate \
     -i /local/spec/frontend-api.yml \
     -g bash \
     --enable-post-process-file  -o /local/clients/cli/ -p apiKeyAuthEnvironmentVariable=API_KEY,generateBashCompletion=true,hostEnvironmentVariable=API_HOST,scriptName=api,generateZshCompletion=true

Example:

API_HOST=https://load-test-int.test.ops.company.se ./api --dry-run getTestJobByName job=systest-stress-pc
curl     -X GET "https://load-test-int.test.ops.company.se/api/v1/tests/sys%09es%09-s%09ress-pc"

should be

API_HOST=https://load-test-int.test.ops.company.se ./api --dry-run getTestJobByName job=systest-stress-pc
curl     -X GET "https://load-test-int.test.ops.company.se/api/v1/tests/systest-stress-pc"

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.