Merged
requested to merge github/fork/etherealjoy/use_optional_wrapper_instead_of_qvariant into master
Created by: etherealjoy
Fixes #8934 (closed)
Issue was due to Optional
support with QVariant
here #8733
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Changes
- QVariant cannot construct user types hence it is not suitable for all cases
- A more intuitive approach is provided, which also shows the type of optional in the api instead of plain
QVariant
- Added handling of optional
body
Function declaration now looks like this
void deletePet(const qint64 &pet_id, const OptionalParam<QString> &api_key = OptionalParam<QString>());
void updatePetWithForm(const qint64 &pet_id, const OptionalParam<QString> &name = OptionalParam<QString>(),
const OptionalParam<QString> &status = OptionalParam<QString>());
instead of this
void deletePet(const qint64 &pet_id, const QVariant &api_key = QVariant());
void updatePetWithForm(const qint64 &pet_id, const QVariant &name = QVariant(), const QVariant &status = QVariant());
User types are supported like this
QList<OAIObject> list;
QMap<QString, OAIObject> map;
QList<QString> strl;
list.append(OAIObject());
api->notifyTopicV1(list);
api->notifyTopicV1();
api->notifyTopicV2();
api->notifyTopicV2(map);
api->notifyTopicV3();
api->notifyTopicV3(strl);
cc @ravinikam @stkrwork @MartinDelille @muttleyxd
@xconverge I had to rework this due to side effects, made a more simpler and intuitive approach.