Skip to content
GitLab

[JS] Fix cookie support in Node.js client

Merged Administrator requested to merge github/fork/delenius/nodejs-cookies into master

Created by: delenius

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

After a change to superagent, the cookie support broke, because they renamed the attachCookies and saveCookies methods, adding underscores in the beginning.

Technically, these methods are considered "private", and this may break again. But for now, this is the easiest fix.

Technical committee: @CodeNinjai @frol @cliffano