Created by: bukowa
This is based on pull request https://github.com/OpenAPITools/openapi-generator/pull/4587 made by @Shogoki as a fix to https://github.com/OpenAPITools/openapi-generator/issues/4586 also https://github.com/kubernetes-client/python/issues/1228 https://github.com/kubernetes-client/python/issues/1215
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
note
I ran only generate-samples.sh
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*
.
For Windows users, please run the script in Git BASH.
-
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@spacether (2020/05)
- I think that using
attr_map
is more obvious than usingjson_keys
- please comment. - Some tests are not passing with strange behaviour please take a look ( https://travis-ci.org/github/bukforks/openapi-generator/builds/760203683#L4574 )
- I think tests regarding chained
attr_map
into_dict
method should be added? - Tests are included only in the
python-flask
samples for now.