Skip to content
GitLab

[QT5] Support optional params using QVariant

Merged Administrator requested to merge github/fork/xconverge/supportOptionalParamsQt5QVariant into master

Created by: xconverge

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Addresses #8648 (closed) in a non-breaking way. Uses QVariant for optional params so that a null can be passed in for optional params.

There is some more discussion and also a version using std::optional (would be a breaking change) on the issue.

I am open to any suggestions and ideas here now that I am a bit more familiar with the codebase

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)