Follow-up for #8235 and a requirement for any move towards Dart NNBD in #8278 (closed) Fixes #5411 (closed)
dart-dio/built_value
-
Disable all fields nullable by default: This is not in line with OAS and will prevent future Dart nullabilty features (NNBD) from being useful as all types would be optional. This is a breaking change with fallback (set
nullableFields=true
). -
Properties are
@nullable
when nullable OR ( not required AND no defaultValue ) -
Support nullable/required fields in JSON
- properties in built_value need to be
@nullable
when they are nullable in OAS or when they are not required in OAS - built_value does not support serializing
null
values by default as it is based on a serialization format based on iterables/lists and not maps - dart-dio uses the built_value json plugin to convert the built_value format to regular json
- by generating a custom serializer for each class we can add support for serializing
null
values if the property is required AND nullable in OAS
- properties in built_value need to be
Dart
- basically just serialize
null
when the field is required and nullable
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)