Created by: 4brunu
Hi, in this PR I updated multiple dependencies of the the kotlin client generator, including Gradle and Kotlin.
Since the Kotlin 1.4.0 requires the Gradle version 5.3 or higher, and the build.gradle
file has a Gradle version specified, we should use that one, because it doesn't match with the Gradle version installed in the CI server.
Starting on Gradle version 5.1, the CI was failling in the unit tests of the kotlin pet projects.
After some digging, I found that it was passing with the Gradle version 4.8, but actually the unit tests are not running, they were skipped.
The unit tests are failling with errors returned from the server with the status code 404
and 405
, so probabily the openapi file used to generate the client is outdated.
Here is the log and an image that shows that.
> Task :compileKotlin UP-TO-DATE
> Task :compileJava NO-SOURCE
> Task :processResources NO-SOURCE
> Task :classes UP-TO-DATE
> Task :compileTestKotlin UP-TO-DATE
> Task :compileTestJava NO-SOURCE
> Task :processTestResources NO-SOURCE
> Task :testClasses UP-TO-DATE
> Task :test
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by worker.org.gradle.internal.reflect.JavaMethod to method java.lang.ClassLoader.getPackages()
WARNING: Please consider reporting this to the maintainers of worker.org.gradle.internal.reflect.JavaMethod
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
BUILD SUCCESSFUL in 7s
3 actionable tasks: 1 executed, 2 up-to-date
16:42:22: Task execution finished 'test'.
I also move the sample kotlin-uppercase-enum.yaml
from bin/configs/other/
to bin/configs/
make sure that that sample is also updated.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jimschubert (2017/09)