Merged
requested to merge github/fork/fl034/swift5-fix-8511-request-closure-not-being-called into master
Created by: fl034
Fixes #8511 (closed)
Self got deallocated due to [weak self]
and no other strong references.
Because of that, request closures wouldn't be called anymore.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.