Skip to content
GitLab

[GO]Change go bytearray typemapping

Closed Administrator requested to merge github/fork/codedevstem/change-go-bytearray-typemapping into 6.0.x

Created by: codedevstem

Breaking changes in generated golang models Sorry for the bait and switch on the other RP, but i messed up my merging and wanted to correct it.

Details

Changes

  • Changes golang typeMapping item byteArray from String to []byte

Verification

  • Line 28 in model_format_test_.go

Impact

  • The following openapi-model would change resulting golang type from String to []byte 
components:
  schemas:
    foo:
       type: string
       format: byte

Before:

Foo String `json:"foo"`

After:

Foo []byte `json:"foo"`

Reviewers

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)

Resolves

Issue: https://github.com/OpenAPITools/openapi-generator/issues/8351

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run 
    mvn clean package
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    to update all Petstore samples related to your fix. Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.