Closed
requested to merge github/fork/codedevstem/bugfix/change-bytearray-from-string-to-byte into 6.0.x
Created by: codedevstem
Potentially BREAKING Changes I think this makes Go more inline with other typed languages like Java. I am a bit unsure how breaking the changes are, would love some pointers here.
Changes
- Changes AbstractGoCodegen typemapping ByteArray value to []byte.
Validation
- Changes can be validated with
model_fomat_test.go
Reviewers
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run mvn clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.