Created by: dhontecillas
Fixes #8392 (closed) with the naive approach of checking if the body type is **os.File
, so it can read its content and avoid the bug of not reading the bytes and having content-length 0.
Tested the fixed code on a separate branch in the same repo used to reproduce the issue : https://github.com/dhontecillas/openapi-generator-go-upload-bug/tree/test_fix (the updated line can be found in https://github.com/dhontecillas/openapi-generator-go-upload-bug/blob/test_fix/pkg/bug/client.go#L415 ). When running the go run .
command in that branch, the bug is not reproduced anymore. We get an output of :
The request failed for a different reason: Post "http://127.0.0.1:8000/upload": dial tcp 127.0.0.1:8000: connect: connection refused
That is the expected result as we do not have any server running.
Can you have a look @antihax @grokify @kemokemo @jirikuncar please ? thank you
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.