Created by: ityuhui
The function *_parseFromJSON()
e.g. pet_t *pet_parseFromJSON(cJSON *petJSON) creates and returns a model pet_t according to the parameter cJSON *petJSON.
If petJSON is not a valid cJSON for pet_t, the function pet_parseFromJSON can not create the model pet_t successfully, and return NULL directly. At this time, some parts of pet_t have been created, e.g. category_local_nonprim, but the function forgets to release its memory, this will cause memory leak.
This PR fixes this memory leak via deleting the memory before return NULL
This PR only covers the type of isModel/complexType for the member of model, does not cover other types e.g. isArray, isFreeFormObject, isMap because now I only have the use case of isModel/complexType. We can fix other types when we meet them in future.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master,5.1.x,6.0.x -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@wing328 @zhemant @michelealbano