Created by: basyskom-dege
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
This PR will rename the generator for cpp-qt5-client
to cpp-qt-client
. The reason behind this, is the release of Qt6. In Qt6 there are some deprecated functions that are "removed" in PR #8234. @wing328 suggested to rename the generator to just Qt
since it now supports Qt5 and Qt6. The only changes are the removal of all occurrences of the 5s in every file. I did not change the cpp-qt5-qhttpengine-server
though since I did not change possibly deprecated functions in this generator.
PING @wing328 @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)