Merged
requested to merge github/fork/devhl-labs/csharp-netcore-httpclient into csharp-netcore-httpclient
This is the beginning changes to move to HttpClient. It was working for my use case before I made the ApiException generic. At the moment it requires some post processing to replace ???? to ? and ??? to ?. This can be appended to the powershell script that begins the creation process in the first place. If this is good, then there is a lot of work to be done.
https://github.com/OpenAPITools/openapi-generator/issues/6800 https://github.com/OpenAPITools/openapi-generator/issues/5375
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.1.x
,6.0.x
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.