Skip to content
GitLab

[dart-dio] Allow dynamic headers and add additional dio parameters

Merged Peter Leibiger requested to merge github/fork/kuhnroyal/dart-dio/api-parameters into master
  • fixes some compile errors due to header params not being of type String
  • add optional extra and validateStatus parameters from dio to API calls

Contains the same changes as https://github.com/OpenAPITools/openapi-generator/pull/6915 and fixes compile issues for dart-dio mentioned in https://github.com/OpenAPITools/openapi-generator/issues/8179.

Regarding the concerns in #6915 about missing changes to the dart generator:

  • dart generator does not expose the header map
  • the http.Client only handles String headers where as dio can handle dynamic headers and does its own serialization of headers

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)