Created by: alfabetacain
Added support for cookie parameters to the jaxrs-spec generator, which should fix #2908 (closed).
Added the test case testGenerateApiWithCookieParameter_issue2908 to JavaJAXRSSpecServerCodegenTest.java, which uses the file issue_2908.yaml for testing that cookie parameter generation works.
Briefly, the fix was adding a new mustache template (cookieParams.mustache) to the jaxrs-spec generator and referencing it in api.mustache in the same way the other parameter types are referenced (e.g. queryParams.mustache).
The new cookieParams.mustache is essentially a copy of the queryParams.mustache.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)