Created by: cowclaw
For inner enum classes, the generators jaxrs-cxf and jaxrs-cxf-client do not properly annotate the generated methods toString (missing @JsonValue) and fromValue (missing @JsonCreator), when the additional property jackson is set.
This bug is only present in enumClass.mustache responsible for inner enum classes. It is not present in enumOuterClass.mustache, which is responsible for regular enum classes.
This bug is resolved by this PR.
Hint for the reviewer: The first commit of this PR introduces a new petstore sample for jaxrs-cxf-client with additional property jackson set to true. The second commit provides the actual fix.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc: @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda