Created by: noordawod
The current generator produces code that won't work when trying to upload a file not part of a multipart-form data.
As an example, the generated code for an API endpoint with a file which is not part of a multipart-form request is as follows:
Future uploadFile(MultipartFile image) {
// ...
}
However, invokeAPI()
doesn't take that into account and only checks for a MultipartRequest
. This pr adds support for sending a single file when uploading non-multipart form data.
plus, added some tlc to the QueryParam
class :)
@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12) @agilob @wing328 @sbu-WBT
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.