Created by: mattmelling
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
The PHP client uses friendsofphp/php-cs-fixer v1.12 for PSR2 analysis. 1,12 doesn't supports PHP up to < 7.2.
PHP >= 7.2 support was added in php-cs-fixer v2 which made some changes to the API and default fixers/rules.
This PR upgrades php-cs-fixer to v2.12. The fixers/rules have been aligned for PSR2 as desired in the original PR on swagger-codegen (#3863). I've changed defaults for some of the rules to prevent lots of whitespace warnings from php-cs-fixer, these typically seem to be down to blank template values and are not raised when using the configuration in master.
Notes
php-cs-fixer added the idea of "risky" fixers in v2. Since the strict_param
and strict_comparison
fixers are considered risky, we must alter the command line to vendor/bin/php-cs-fixer fix --dry-run --diff -vvv --allow-risky yes
even when using --dry-run
.
/cc @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @ybelenko