Created by: lightman73
While trying to implement @4brunu suggestion for token refresh ( https://github.com/OpenAPITools/openapi-generator/issues/5462#issuecomment-592417371 ), with an access token configured in customHeaders with key "Authorization", I noticed that after changing the value in the customHeaders in the TokenRefresher, and then calling shouldRetry(true), the following call would still use the old access token value.
Looking into the issue I noticed that the new value (set via MyAPI.customHeaders.updateValue(accessToken, forKey: "Authorization") before calling shouldRetry(true) was being overwritten with the old one stored in self.headers in the createURLRequest function defined in URLSessionImplementations.swift.
The proposed change creates the new headers for the modifiedRequest by adding the customHeaders last, so that they can overwrite the keys stored in self.headers, thus fixing the problem.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@jgavris @ehyche @Edubits @jaz-ah @4brunu