some Java implementations don't honor .relativize documentation fully. When outDir is /a/b and the input is /a/b/c/d, the result should be c/d. Some implementations make the output ./c/d which seems to mix the logic as documented for symlinks. So we need to trim any / or ./ from the start, as nobody should be generating into system root and our expectation is no ./
This resolves regeneration issues for those on such Java implementations, although we've not been able to track down the exact vendor or configurations which might lead to these differences.
cc @OpenAPITools/generator-core-team
cc @sebastien-rosset I believe you were affected by this FILES issue? If so, would you mind checking against this branch to see if it's resolved?
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.