Created by: ParakhMittal
Issue Fix for #7258 (closed)
In scala-akka-client code that is getting generated, addAuthentication method is called after setting headers using header parameter in the below mentioned line addAuthentication(request.credentials)( httpRequest.withHeaders(headers(request.headerParams)) )
However, in addAuthentication method, we are using withHeaders method that overwrites the headers set using header parameters. So, I am proposing to change the addAuthentication method be replacing withHeaders() method to addHeader() to add authentication header to the list of already existing headers.
Technical Committee for Scala @clasnake (2017/07), @jimschubert (2017/09) , @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master -
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.