Created by: gmtstephane
Hi, in the Go server, we can only have Status code 200 or 500 wether our implementation function return an error or not.
In case or error (err!=nil), the server write the status code 500 without any messages .
result, err := c.service.AddPet(*pet)
if err != nil {
w.WriteHeader(500)
return
}
EncodeJSONResponse(result, nil, w)
In many cases, their can be several types of error in our implementation, and i wouldlike to return the error message to the client. I suggest to Encode the response with the result variable, with the statuscode 500, which will let us write responses in case of error.
if err != nil {
statusCode := 500
EncodeJSONResponse(result, &statusCode, w)
return
}
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07) @wing328
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.