Related to #7001, this updates the images for CLI + Online to use the consistent base image of openjdk:8-jre-alpine
(java:8-*
is no longer maintained).
This also updates .hub.cli.dockerfile
and .hub.online.dockerfile
(which are used in our Docker Hub automated builds) to use my jimschubert/8-jdk-alpine-mvn:bash-2.0
as the base builder image. This image is rebuilt weekly and has bash pre-installed in the image. This isn't a huge deal as it is a builder image and we don't have build slowness on Docker Hub, but it's best to stay up to date.
This does not touch the Dockerfile discussed in #7001 because there's already work from a contributor there. Plus, that Dockerfile isn't used for anything other than local development. We don't have insight into how often people use that Dockerfile or whether they prefer it over run-in-docker.sh
in the project root, which effectively does the same thing.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.