Skip to content
GitLab

Fixed the generation of model properties whose data type is a composed (allOf) schema

Merged Administrator requested to merge github/fork/rubms/#582_Fixed_generation_of_properties_of_composed_schemas into master

Created by: rubms

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixed issue #582 (closed). The problem came from the https://github.com/OpenAPITools/openapi-generator/commit/a897feef50989d8b0d0238c067eebaef4f7f6c70 commit in the https://github.com/OpenAPITools/openapi-generator/pull/360 pull request. After that commit, the generation of model properties whose data type is a composed (allOf) schema was broken: the data type name of the generated property was that of the first model participating in the allOf clause.

After this fix the property data type is again as expected: the one of the composed schema and not one of its parents (models involved in an allOf clause).

cc @jmini @wing328