Created by: ftsanjuan
Description This is a template-only change for the typescript-fetch generator.
It includes the addition of two methods to the runtime.ts
file for serializing an array of objects stored requestParameters
into the formData
instance.
Problem
Previously, a .join()
would be called on a particular parameter within requestParameter
regardless of whether or not it contained an array of objects or an array of strings. This resulted a string of [object Object]
strings getting inserted into a key within the formData
instance.
Solution
This change allows for an array of objects to be inserted into the formData
instance by iterating over each object and its properties and appending it into the properly named formData
key to preserve its nesting (as an array of objects)
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.