Created by: sbu-WBT
Double gets special special treatment in the mustache to prevent some errors like type 'int' is not a subtype of type 'double'
.
Dart has no floats so they are replaced with doubles. Before this fix, it wasn't the case inside the mustache file so the floats had the type double
in the class, but not the code from the isDouble
block inside the mustache because only isFloat
was true.
PR checklist
-
Read the contribution guidelines. -
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand. -
Run the shell script ./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)